On Thu, Jan 29, 2009 at 08:47:04PM +0530, Bob Copeland wrote: > > + struct delayed_work ath_led_blink_work; > > + int led_on_duration; > > + int led_off_duration; > > + int led_on_cnt; > > + int led_off_cnt; > > This is something that has come up from time to time from users for > ath5k as well. Half of the drivers now have their own timers for > turning leds on or off. > > Can we just add a decent blink algorithm to mac80211? Right now for > rx it just toggles every other packet. For tx, it's slightly smarter > but not overly so. It seems like this is one of those things everyone > wants to do and we could easily make it a standard service. ath9k maps all four led functionality (radio, assoc, rx and tx) into a single LED, I think ath5k is also doing in the similar way. But other drivers can map their led functionality differently in their h/w where the pattern will differ. mac80211 is already signalling appropriate leds, imho it is up to the driver to define the pattern based on the number of leds available/configured. > > -- > Bob Copeland %% www.bobcopeland.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
