On Tue, 2009-01-27 at 18:50 -0800, Luis R. Rodriguez wrote:
> Monitor mode is able to TX by using injected frames. We should
> not allow injected frames to be sent unless allowed by regulatory
> rules. Since AP mode uses a monitor interfaces to transmit
> management frames we have to take care to not break AP mode as
> well while resolving this. We deal with this by allowing compliant
> APs solutions to inform mac80211 if their monitor interface is
> intended to be used for an AP by setting a cfg80211 flag for the
> monitor interface. hostapd, for example, currently does its own
> checks to ensure AP mode is not used on channels which require radar
> detection. Once such solutions are available it can can enable this
> flag.
> Signed-off-by: Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx>
Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
if you fix the indentation here:
> + * Since AP mode uses monitor interfaces to inject/TX management
> + * frames we make AP mode the exception to this rule as its
> + * implementation can deal with radar detection by itself.
> + */
> + if (!(sdata->u.mntr_flags & MONITOR_FLAG_AP_MGT) &&
> + (chan->flags & (IEEE80211_CHAN_NO_IBSS |
> + IEEE80211_CHAN_RADAR |
> + IEEE80211_CHAN_PASSIVE_SCAN)))
> + goto fail;
to indent like this:
if (...
(chan->flags & (.. |
.. |
..)))
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
