On Wed, Jan 28, 2009 at 02:17:21AM -0800, Johannes Berg wrote: > On Tue, 2009-01-27 at 18:52 -0800, Luis R. Rodriguez wrote: > > > + mutex_lock(&cfg80211_drv_mutex); > > + regd = reg_get_current_rd(); > > + mutex_unlock(&cfg80211_drv_mutex); > > + > > + if (!regd) > > + goto out; > > Any reason you need to copy and can't just build the whole thing under > lock? Glad you asked, we can lock the entire call or we can do the above to copy. I picked a copy to not let a regular user (get reg can be called by anyone) abuse the lock as cfg80211_drv_mutex is used in a lot of places, I guess its silly but other's input on this is appreciated as well. Not sure if the copy was the best choice. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
