On Wed, Jan 28, 2009 at 01:52:17PM +0200, Tomas Winkler wrote: > On Wed, Jan 28, 2009 at 1:37 PM, Samuel Ortiz <samuel@xxxxxxxxxx> wrote: > > On Wed, Jan 28, 2009 at 09:12:48AM +0200, Tomas Winkler wrote: > >> On Wed, Jan 28, 2009 at 1:31 AM, Jason Andryuk <jandryuk@xxxxxxxxx> wrote: > >> >> No, that's just a consequence of the bug, not the bug itself. > >> >> Would you mind applying this patch on top of your latest wireless-testing tree > >> >> and testing 3945 with it ? Thanks for your patience. > >> > > >> > The patch did not cleanly apply, but I just removed the lines > >> > indicated in the patch. It crashed with a NULL pointer dereference. > >> > >> Samuel > >> It was really wrong try, you cannot just leave place where firmware > >> updated read pointer unallocated. I would rather focus on differences > >> introduced by this patch. > > Well, that's what I did. I neglected to check if rb_stts were actually used. > > > > > >> commit 738910c064ff461051cd37e17199f270ff88a9a3 iwl3945: use rx queue > >> management infrastructure from iwlcore is the first to trigger the > >> BUG_ON. However, prior versions would dereference a NULL pointer > >> before the driver could get far enough to trigger the BUG_ON. > > I know, that's what Jason described. > > I think I now understand why. Prior to > > 738910c064ff461051cd37e17199f270ff88a9a3, you introduced > > c2a0aa3cb733452e749727680e380dca6cc10a68 without actually allocating the > > rb_stts pointer, which was really wrong too. > > Yes I made mistake then I tought that 3945 take also init path of agn > already... Now it's hard to besect :(. > I suspect the rx queue managment infrastructure more because we brohgt > iwlagn bug into 3945 I guess it wrong rx buffer index handling. It's > really important we nail it now this will solve also our troubles in > iwlagn, where it get lost upon tons of patches. I agree. I also suspect that a lot more people will report the same problem when this code leaves wireless-testing for upstream inclusion. Cheers, Samuel. > Thanks > Tomas -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
