It seems mails from Flameeyes just do not make it through to linux-wireless, so there it is. Please apply this and consider releasing 1.0.1 (without a v in the tarball name, if at all possible). Thanks, Tony V.
--- Begin Message ---
- To: linux-wireless@xxxxxxxxxxxxxxx
- Subject: [PATCH] Fix building with --as-needed.
- From: Diego Elio 'Flameeyes' Pettenò <flameeyes@xxxxxxxxx>
- Date: Sat, 24 Jan 2009 17:50:31 +0100
- Authentication-results: gold.linx.net (amavisd-new); dkim=pass header.i=@xxxxxxxxx
- Authentication-results: gold.linx.net (amavisd-new); domainkeys=pass header.from=flameeyes@xxxxxxxxx
- Cc: Tony Vroon <tony@xxxxxxxx>, Diego E. 'Flameeyes' Pettenò <flameeyes@xxxxxxxxx>
From: Diego E. 'Flameeyes' Pettenò <flameeyes@xxxxxxxxx> For --as-needed to work (and for traditional ld too) the libraries should always be passed _after_ the object files, move them so that they are picked up properly. Also rename LIBS to NLLIBS to avoid confusion between LIBS/LDLIBS. --- Makefile | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index a07fbcf..aaa9ca6 100644 --- a/Makefile +++ b/Makefile @@ -48,11 +48,11 @@ endif ifeq ($(NL2FOUND),Y) CFLAGS += -DCONFIG_LIBNL20 -LIBS += -lnl-genl +NLLIBS += -lnl-genl NLLIBNAME = libnl-2.0 endif -LIBS += `pkg-config --libs $(NLLIBNAME)` +NLLIBS += `pkg-config --libs $(NLLIBNAME)` CFLAGS += `pkg-config --cflags $(NLLIBNAME)` ifeq ($(V),1) @@ -85,7 +85,7 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem) crda: reglib.o crda.o $(NQ) ' LD ' $@ - $(Q)$(CC) $(CFLAGS) $(LDFLAGS) $(LIBS) -o $@ $^ $(LDLIBS) + $(Q)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(NLLIBS) regdbdump: reglib.o regdbdump.o print-regdom.o $(NQ) ' LD ' $@ -- 1.6.1
--- End Message ---
Attachment:
signature.asc
Description: This is a digitally signed message part
