On Wednesday 21 January 2009 21:06:54 Larry Finger wrote:
> Christian Lamparter wrote:
> > This patch fixes a long standing issue in p54usb.
> >
> > Under high memory pressure, dev_alloc_skb couldn't always allocate a
> > replacement skb. In such situations, we had to free the associated urb.
> > And over the time all urbs were eventually gone altogether and
> > obviously the device remained mute from then on.
>
> With this patch, I get lots of missing rx_refill_* messages such as
>
> drivers/net/wireless/p54/p54usb.c:1024: error: ‘struct p54u_priv’ has no member named
> ‘rx_refill_work’
> drivers/net/wireless/p54/p54usb.c:1025: error: ‘struct p54u_priv’ has no member named
> ‘rx_refill_lock’
> drivers/net/wireless/p54/p54usb.c:1026: error: ‘struct p54u_priv’ has no member named
> ‘rx_refill_list’
>
> Did I miss a patch? I did a search for the string "rx_refill" in my entire mailbox and
> found only this mail and Artur's reply.
>
No, you don't miss anything... here's the other p54usb.h change.
Sorry!
Regards,
Chr
---
diff --git a/drivers/net/wireless/p54/p54usb.h b/drivers/net/wireless/p54/p54usb.h
index 8bc5898..04c7258 100644
--- a/drivers/net/wireless/p54/p54usb.h
+++ b/drivers/net/wireless/p54/p54usb.h
@@ -134,6 +134,10 @@ struct p54u_priv {
spinlock_t lock;
struct sk_buff_head rx_queue;
+ spinlock_t rx_refill_lock;
+ struct list_head rx_refill_list;
+ struct work_struct rx_refill_work;
+
struct usb_anchor submitted;
};
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
