Hi,
Am Mittwoch, 21. Januar 2009 schrieb Reinette Chatre:
> From: Samuel Ortiz <samuel.ortiz@xxxxxxxxx>
>
> Here again, the rfkill routines are duplicated between agn and 3945. Let's
> move the agn one to iwlcore, and so we can get rid of the 3945 ones.
[...]
> +void iwl_bg_rf_kill(struct work_struct *work)
> +{
> + struct iwl_priv *priv = container_of(work, struct iwl_priv, rf_kill);
> +
> + wake_up_interruptible(&priv->wait_command_queue);
> +
> + if (test_bit(STATUS_EXIT_PENDING, &priv->status))
> + return;
> +
> + mutex_lock(&priv->mutex);
> +
> + if (!iwl_is_rfkill(priv)) {
> + IWL_DEBUG(IWL_DL_RF_KILL,
> + "HW and/or SW RF Kill no longer active, restarting "
> + "device\n");
> + if (!test_bit(STATUS_EXIT_PENDING, &priv->status))
> + queue_work(priv->workqueue, &priv->restart);
I've changed this check in both rf-kill patches (3945 and agn) to
if (!test_bit(STATUS_EXIT_PENDING, &priv->status) &&
test_bit(STATUS_ALIVE, &priv->status))
in order to avoid restarting the adapter when notified about rfkill changes
by interrupt/polling.
I guess this is just an oversight, right?
Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
