Christian Lamparter <chunkeey@xxxxxx> writes: > On Friday 16 January 2009 20:33:43 Kalle Valo wrote: >> N800 and N810 support is not on mainline yet, for stlc45xx I decided >> to add module parameters for the gpio numbers. Here's the commit from >> stlc45xx repo: >> >> http://gitorious.org/projects/stlc45xx/repos/mainline/commits/35afc5df0027d02d49e6f5bf986dcc4deb4ee6cf > > This is the same patch for p54spi. > It removes all N800/N810 specific code from p54spi, so the driver can be used on > other architectures, or configurations as well. > > Signed-off-by: Christian Lamparter <chunkeey@xxxxxx> > --- > All in favour with these changes? No complaints from me. > +/* > + * gpios should be handled in board files and provided via platform data, > + * but because it's currently impossible for p54spi to have a header file > + * in include/linux, let's use module paramaters for now > + */ For stlc45xx, being an out-of-tree driver, it was impossible to have a header file for the platform data. But p54spi is a proper in-tree driver and it shouldn't have that problem. But that's the next step, it shouldn't hold off this patch. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
