Search Linux Wireless

Re: [PATCH V2] b43: Eliminate compilation warning in b43_op_set_key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 14 January 2009 18:15:25 Larry Finger wrote:
> A recent pull from wireless testing generates the following warning:
>  
>    CC [M]  drivers/net/wireless/b43/main.o
>  drivers/net/wireless/b43/main.c: In function ‘b43_op_set_key’:
>  drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatch
>  in conditional expression
> 
> This fix was suggested by Johannes Berg <johannes@xxxxxxxxxxxxxxxx>.
> 
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>

ACK

> ---
> 
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -3535,6 +3535,9 @@ static int b43_op_set_key(struct ieee802
>  	u8 algorithm;
>  	u8 index;
>  	int err;
> +#if B43_DEBUG
> +	static const u8 bcast_addr[ETH_ALEN] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
> +#endif
>  
>  	if (modparam_nohwcrypt)
>  		return -ENOSPC; /* User disabled HW-crypto */
> @@ -3633,7 +3636,7 @@ out_unlock:
>  		b43dbg(wl, "%s hardware based encryption for keyidx: %d, "
>  		       "mac: %pM\n",
>  		       cmd == SET_KEY ? "Using" : "Disabling", key->keyidx,
> -		       sta ? sta->addr : "<group key>");
> +		       sta ? sta->addr : bcast_addr);
>  		b43_dump_keymemory(dev);
>  	}
>  	write_unlock(&wl->tx_lock);
> 
> 



-- 
Greetings, Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux