On Tue, Jan 13, 2009 at 06:20:25PM -0600, Larry Finger wrote:
> A recent pull from wireless testing generates the following warning:
>
> CC [M] drivers/net/wireless/b43/main.o
> drivers/net/wireless/b43/main.c: In function ‘b43_op_set_key’:
> drivers/net/wireless/b43/main.c:3636: warning: pointer type mismatch
> in conditional expression
>
> This fix was suggested by Johannes Berg <johannes@xxxxxxxxxxxxxxxx>.
>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -3630,10 +3630,12 @@ static int b43_op_set_key(struct ieee802
>
> out_unlock:
> if (!err) {
> + u8 bcast[ETH_ALEN];
> + memset(bcast, 0xff, ETH_ALEN);
Isn't there a statically-allocated array w/ the broadcast MAC in it
somewhere already?
> b43dbg(wl, "%s hardware based encryption for keyidx: %d, "
> "mac: %pM\n",
> cmd == SET_KEY ? "Using" : "Disabling", key->keyidx,
> - sta ? sta->addr : "<group key>");
> + sta ? sta->addr : bcast);
> b43_dump_keymemory(dev);
> }
> write_unlock(&wl->tx_lock);
>
--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
