On Tue, Jan 13, 2009 at 3:23 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2009-01-13 at 15:17 -0800, Luis R. Rodriguez wrote: >> > (2) you >> > should not do via the regulatory code and the notifier but rather by not >> > registering those channels to start with >> >> I did a lot of this work because you had opposed to allow drivers dynamically register >> their channels. > > I think we may have had some miscommunication here? I didn't like > registering the channels dynamically with new calls, but I certainly > don't care how you arrive at your channel array, you can kmalloc it if > you want. It seems like it, anyway I'd prefer we use a static set of channels. >> The size of the code also increases considerably by using static set of >> channels for each custom regulatory domain, its possible though. > > You don't have to. > >> >, or setting the disabled flag >> > before registration if that's easier. >> >> You'll still need some sort of table. Either way -- all these are options of how to >> accomplish the same task. I did this as part of cfg80211 as I figured it could be >> used by other drivers. > > In what form do you have this data? I posted the respective ath9k patch. > Is it "valid 2412-2472 and 4950-5250 > MHz"? Yes, with flags, it consists of 5 static ieee80211_regdomain structs and a helper to change flags where required. > If so, can we just have a function that marks all channel that > would fall outside these ranges as invalid, and you call that function > with a specific band and channel before registering your wiphy? Yeah that would work too. Only other thing I can think about is that of us requiring custom preferences on the regulatory flags when on the world regulatory domains. For now we have only one such custom rule: - Do not allow adhoc on 5 GHz unless specified by country IE -- only when on some specific world regulatory domains. The other regdomains must follow the world regdomain / country rule. The active / passive scan stuff is dealt with in similar with in the patch I posted but that's just to condense the number of world regulatory domain structs to 5. I suppose the above custom rule I mentioned could just be dealt with on the reg_notifier(). Hmm -- yeah I like your suggestion. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
