Search Linux Wireless

Re: [PATCH] nl80211: New command for adding extra IE(s) into management frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2009-01-13 at 13:51 +0200, Jouni Malinen wrote:

> +	if (params->ies) {
> +		ies = kmalloc(params->ies_len, GFP_KERNEL);
> +		if (ies == NULL)
> +			return -ENOMEM;
> +		ies_len = params->ies_len;
> +		memcpy(ies, params->ies, ies_len);

kmemdup? Might also make sense to not try the allocation if we're going
to refuse it anyway, but that might be complicated to do and probably
doesn't matter.

Otherwise looks good to me.

Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux