Hi Dan, that sounds better: I've asked John to please go ahead and revert it and we'll send a new version that just packs all of the structs. Thanks! -Andrey On Mon, Jan 12, 2009 at 11:37 AM, Dan Williams <dcbw@xxxxxxxxxx> wrote: > On Mon, 2009-01-12 at 11:04 -0800, Andrey Yurovsky wrote: >> Hi Dan, Johannes was correct -- the explicit get_unaligned_ was not >> needed and using packed was required. Unfortunately our patch got >> merged before we had a chance to send a version including just the >> packing, so I'm preparing a patch that reverts the calls to >> get_unaligned_* ...this is, however, independent of the actual >> if_spi.c driver patch. > > Yes, they are independent. Alternatively, you could just ask John to > revert the patch, and then provide a new patch with just the 'packed' > bits, which might be cleaner in the git history. > > Dan > > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html