On 17/03/2025 05:55, feng.wei8@xxxxxxxxxx wrote: > I see the following commit: > |https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ab936836ec09fa23954e8e5785d71a41e5ee8bcb I do not see Johannes merged that. Do you understand how Git and kernel process work? > > I don't think code optimization and unification is "garbage". If so, why did you choose to merge into a commit like "garbage". > I'm just bothered by this aspect when I usually look at the code, so why not be concise. No, you just run some static tools, coccinelle or whatever else and flood us with patches all over the tree, claiming that they improve anything. Nothing here was done in terms of choice of improvement but it's pure automation. In many places it was already pointed out that your automation is not even correct. > I would even like to implement `min4/max4` like `dml_min4/dml_max4`. Wouldn't that be more concise code? > > As a newcomer, my perspectives may differ from those of the experts here. I apologize if this has caused any inconvenience. Best regards, Krzysztof