Search Linux Wireless

RE: [PATCH v9 RESEND] wifi: mt76: mt7915: add wds support when wed is enabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >>
> >>    	mt76_connac_mcu_del_wtbl_all(&dev->mt76);
> >>
> >> -	if ((mtk_wed_device_active(&dev->mt76.mmio.wed) &&
> >> -	     is_mt7915(&dev->mt76)) ||
> >> -	    !mtk_wed_get_rx_capa(&dev->mt76.mmio.wed))
> >> -		mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(CAPABILITY), 0, 0, 0);
> >> +#if IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED)
> >
> > In MT76, there are two styles:
> >    #if IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED)
> >    #ifdef CONFIG_NET_MEDIATEK_SOC_WED
> >
> > I think both are correct. Just wonder why not making them consistent.
> Seems you didn't receive Felix's email, check this:
> https://lore.kernel.org/linux-wireless/71ed8398-4619-4793-804d-77cad36e7402@xxxxxxxx/
> 

I was aware of this. Felix pointed out 'if (IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED))'
will lead build error. But what I mentioned here were '#if' and
'#ifdef' (preprocess directive).

Anyway, ignore this.





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux