On 3/6/2025 5:38 PM, Johannes Berg wrote:
On Mon, 2025-03-03 at 21:37 +0530, Sarika Sharma wrote:
This looks like it's missing the roll-up to the global counters and
timestamps? Why would that not break backward compatibility?
For non-MLO it will not effect, for MLO I have added accumulated stats
for packets, bytes and signal, rates at mld level.
For inactive time, DTIM period, beacon interval can I add least of the
values among links ? and add as a separate patch?
I guess some like DTIM period / beacon interval don't really make sense,
but for some others we should have it it?
Sure, since we are not sure what application wants, so will keep the
entry there as well.
Not sure why it should be a separate patch but I guess it doesn't matter
_too_ much, hopefully nobody will need to bisect this specific feature
...
But honestly you could almost just add the roll-up support in cfg80211
*before* you even split it in mac80211, it just won't do anything until
mac80211 reports per-link values?
Okay, may be I can include these changes in patch "add additional MLO
statistics" itself and add that patch before 07/12 patch.
