On 3/6/2025 2:43 AM, Miri Korenblit wrote:
> From: Anjaneyulu <pagadala.yesu.anjaneyulu@xxxxxxxxx>
>
> Implemented configuration option for channel properties to allow
> soft AP/active scan operations exclusively to 20 MHz bandwidth.
why "soft"? is this not applicable to "regular" APs? P2P GO?
would be better to first describe the actual problem, and then describe the
solution. and use imperative voice.
> While on it, fixed indentation and kernel doc for
> enum nl80211_reg_rule_flags.
>
> Signed-off-by: Pagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@xxxxxxxxx>
doesn't match "From:"
> Signed-off-by: Somashekhar Puttagangaiah <somashekhar.puttagangaiah@xxxxxxxxx>
> Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@xxxxxxxxx>
...
> enum nl80211_reg_rule_flags {
> - NL80211_RRF_NO_OFDM = 1<<0,
> - NL80211_RRF_NO_CCK = 1<<1,
> - NL80211_RRF_NO_INDOOR = 1<<2,
> - NL80211_RRF_NO_OUTDOOR = 1<<3,
> - NL80211_RRF_DFS = 1<<4,
> - NL80211_RRF_PTP_ONLY = 1<<5,
> - NL80211_RRF_PTMP_ONLY = 1<<6,
> - NL80211_RRF_NO_IR = 1<<7,
> - __NL80211_RRF_NO_IBSS = 1<<8,
> - NL80211_RRF_AUTO_BW = 1<<11,
> - NL80211_RRF_IR_CONCURRENT = 1<<12,
> - NL80211_RRF_NO_HT40MINUS = 1<<13,
> - NL80211_RRF_NO_HT40PLUS = 1<<14,
> - NL80211_RRF_NO_80MHZ = 1<<15,
> - NL80211_RRF_NO_160MHZ = 1<<16,
> - NL80211_RRF_NO_HE = 1<<17,
> - NL80211_RRF_NO_320MHZ = 1<<18,
> - NL80211_RRF_NO_EHT = 1<<19,
> - NL80211_RRF_PSD = 1<<20,
> - NL80211_RRF_DFS_CONCURRENT = 1<<21,
> - NL80211_RRF_NO_6GHZ_VLP_CLIENT = 1<<22,
> - NL80211_RRF_NO_6GHZ_AFC_CLIENT = 1<<23,
> - NL80211_RRF_ALLOW_6GHZ_VLP_AP = 1<<24,
> + NL80211_RRF_NO_OFDM = 1 << 0,
> + NL80211_RRF_NO_CCK = 1 << 1,
> + NL80211_RRF_NO_INDOOR = 1 << 2,
> + NL80211_RRF_NO_OUTDOOR = 1 << 3,
> + NL80211_RRF_DFS = 1 << 4,
> + NL80211_RRF_PTP_ONLY = 1 << 5,
> + NL80211_RRF_PTMP_ONLY = 1 << 6,
> + NL80211_RRF_NO_IR = 1 << 7,
> + __NL80211_RRF_NO_IBSS = 1 << 8,
> + NL80211_RRF_AUTO_BW = 1 << 11,
> + NL80211_RRF_IR_CONCURRENT = 1 << 12,
> + NL80211_RRF_NO_HT40MINUS = 1 << 13,
> + NL80211_RRF_NO_HT40PLUS = 1 << 14,
> + NL80211_RRF_NO_80MHZ = 1 << 15,
> + NL80211_RRF_NO_160MHZ = 1 << 16,
> + NL80211_RRF_NO_HE = 1 << 17,
> + NL80211_RRF_NO_320MHZ = 1 << 18,
> + NL80211_RRF_NO_EHT = 1 << 19,
> + NL80211_RRF_PSD = 1 << 20,
> + NL80211_RRF_DFS_CONCURRENT = 1 << 21,
> + NL80211_RRF_NO_6GHZ_VLP_CLIENT = 1 << 22,
> + NL80211_RRF_NO_6GHZ_AFC_CLIENT = 1 << 23,
> + NL80211_RRF_ALLOW_6GHZ_VLP_AP = 1 << 24,
> + NL80211_RRF_ALLOW_20MHZ_ACTIVITY = 1 << 25,
if you are modifying, why not use BIT()
