Search Linux Wireless

RE: [PATCH v2 1/6] wifi: mt76: mt7925: load the appropriate CLC data based on hardware type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > +       struct evt {
> > > +               u8 rsv[4];
> > > +
> > > +               __le16 tag;
> > > +               __le16 len;
> > > +
> > > +               __le32 ver;
> > > +               __le32 addr;
> > > +               __le32 valid;
> > > +               __le32 size;
> > > +               __le32 magic_num;
> > > +               __le32 type;
> > > +               __le32 rsv1[4];
> > > +               u8 data[32];
> > > +       } __packed * res;
> > 
> > nit: no need space between * and res, i.e. "__packed *res".
> > 
> Hi Ping-Ke,
> 
> I also think this is better, but this was suggested to me by
> script/checkpatch.pl.
>

checkpatch says "CHECK:SPACING: spaces preferred around that '*'" for this
case, because it treats as a binary operator, so this is a false alarm. 

By the way, "git grep "__packed \* " drivers/net/wireless/" can see many
similar instances I guess they are also suggested by checkpatch. 






[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux