On 2/28/2025 4:46 AM, Johannes Berg wrote:
> On Fri, 2025-01-17 at 17:53 -0800, Muna Sinada wrote:
>> +static void ieee80211_update_apvlan_links(struct ieee80211_sub_if_data *sdata)
>> +{
>> + struct ieee80211_sub_if_data *vlan;
>> + struct ieee80211_link_data *link;
>> + u16 master_links = sdata->vif.valid_links;
>> + u16 new_links, vlan_links;
>> + unsigned long add;
>> +
>> + list_for_each_entry(vlan, &sdata->u.ap.vlans, u.vlan.list) {
>> + int link_id;
>> +
>> + if (!vlan)
>> + continue;
>> +
>> + /* No support for 4addr with MLO yet */
>> + if (vlan->wdev.use_4addr)
>> + return;
>
> That's weird, how would it happen that the vlan has 4-addr but you
> cannot check the main 'sdata' value? We don't even let you set that, I
> believe?
>
The AP_VLAN interface type is utilized by two features currently:
Dynamic VLAN and WDS (4addr). I am extending the AP_VLAN MLO link
handling when utilizing Dynamic VLAN. MLO 4addr feature will also
utilize this link handling but since the feature itself has not been
supported yet, I am checking for it and highlighting that the feature
is not supported yet.
