On Wed, 2025-01-29 at 21:22 +0530, Roopni Devanathan wrote:
>
> + result = rdev_set_wiphy_params(rdev, radio_id, changed);
> + if (result) {
> + rdev->wiphy.retry_short = old_retry_short;
> + rdev->wiphy.retry_long = old_retry_long;
> + rdev->wiphy.frag_threshold = old_frag_threshold;
> + rdev->wiphy.rts_threshold = old_rts_threshold;
> + rdev->wiphy.coverage_class = old_coverage_class;
> + rdev->wiphy.txq_limit = old_txq_limit;
> + rdev->wiphy.txq_memory_limit = old_txq_memory_limit;
> + rdev->wiphy.txq_quantum = old_txq_quantum;
> + return result;
> + }
> +
> + for (i = 0 ; i < rdev->wiphy.n_radio; i++) {
> + rdev->wiphy.radio_cfg[i].rts_threshold =
> + rdev->wiphy.rts_threshold;
> + }
>
The order here also seems really odd? That basically means the driver
now needs to propagate it to all the radios, but you still have
different per-radio values at that point, that seems bad. You also
didn't even document any such assumptions.
johannes
