Search Linux Wireless

Re: [PATCH] wifi: mac80211: remove debugfs dir for virtual monitor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Alexander
---
  net/mac80211/driver-ops.c | 10 ++++++++--
  net/mac80211/iface.c      | 11 ++++++-----
  2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/net/mac80211/driver-ops.c b/net/mac80211/driver-ops.c
index 299d38e9e863..2fc60e1e77a5 100644
--- a/net/mac80211/driver-ops.c
+++ b/net/mac80211/driver-ops.c
@@ -116,8 +116,14 @@ void drv_remove_interface(struct ieee80211_local *local,
sdata->flags &= ~IEEE80211_SDATA_IN_DRIVER; - /* Remove driver debugfs entries */
-	ieee80211_debugfs_recreate_netdev(sdata, sdata->vif.valid_links);
+	/*
+	 * Remove driver debugfs entries.
+	 * The virtual monitor interface doesn't get a debugfs
+	 * entry, so it's exempt here.
+	 */
+	if (sdata != local->monitor_sdata)
+		ieee80211_debugfs_recreate_netdev(sdata,
+						  sdata->vif.valid_links);

With make W=1 C=1 I'm seeing the following which I think is a result of this
patch:

net/mac80211/driver-ops.c:124:19: error: incompatible types in comparison expression (different address spaces):
net/mac80211/driver-ops.c:124:19:    struct ieee80211_sub_if_data *
net/mac80211/driver-ops.c:124:19:    struct ieee80211_sub_if_data [noderef] __rcu *



That should be fixed with
https://lore.kernel.org/linux-wireless/20250213214330.6113-1-Alexander@xxxxxxxxxxxxxx/

It has been accepted in the last days, but looks like it was too late for wt-2025-02-25.

Alexander




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux