On 19/02/2025 08:20, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
>> The TX queues should be woken when there are at least 4 available
>> entries, not when there are at most 4.
>>
>> Tested with RTL8821AE.
>>
>> Fixes: d0311314d002 ("rtlwifi: rtl8192ee: Fix handling of new style descriptors")
>
> I agree your change looks more reasonable. Did you really meet the case
> and this patch solves it?
>
> By the changes of d0311314d002, I can't really understand why the initial
> version and the commit do. Considering the commit "fix" some situations,
> I don't know if this patch would break them again. Could you look into
> rtlwifi PCI flow deeper and share your ideas?
>
I saw several problems with rtl8821ae but I can't say if this
patch fixes any of them:
- After a few hours it randomly stops receiving beacons and data
frames for at least 10 seconds ("AP off, try to reconnect now"
in dmesg). Then it may or may not be able to reconnect.
- Sometimes the TX speed measured by iperf3 is limited to ~80 Mbps.
Normally it's over 250.
- Sometimes there are duplicate pings:
19 packets transmitted, 14 received, +151 duplicates, 26.3158% packet loss, time 18098ms
- Testing the RX speed with iperf3 sometimes makes the mouse cursor
stutter. (It's usually ~300 Mbps.)
I don't know how to reproduce any of these.
<= seemed like a clear, simple mistake. I'm not sure about it
anymore, so please drop the patch. Maybe I will look into it
again some time.
