Search Linux Wireless

Re: [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: <shaw.leon@xxxxxxxxx>
Subject: Re: [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init()
From: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
Date: Thu, 20 Feb 2025 19:26:29 -0800
Cc: <alex.aring@xxxxxxxxx>, <andrew+netdev@xxxxxxx>, <b.a.t.m.a.n@xxxxxxxxxxxxxxxxxxx>, <bpf@xxxxxxxxxxxxxxx>, <bridge@xxxxxxxxxxxxxxx>, <davem@xxxxxxxxxxxxx>, <donald.hunter@xxxxxxxxx>, <dsahern@xxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <herbert@xxxxxxxxxxxxxxxxxxx>, <horms@xxxxxxxxxx>, <kuba@xxxxxxxxxx>, <kuniyu@xxxxxxxxxx>, <linux-can@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-kselftest@xxxxxxxxxxxxxxx>, <linux-ppp@xxxxxxxxxxxxxxx>, <linux-rdma@xxxxxxxxxxxxxxx>, <linux-wireless@xxxxxxxxxxxxxxx>, <linux-wpan@xxxxxxxxxxxxxxx>, <miquel.raynal@xxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <osmocom-net-gprs@xxxxxxxxxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <shuah@xxxxxxxxxx>, <stefan@xxxxxxxxxxxxxxxxxx>, <steffen.klassert@xxxxxxxxxxx>, <wireguard@xxxxxxxxxxxxxxx>
In-reply-to: <20250219125039.18024-6-shaw.leon@gmail.com>
References: <20250219125039.18024-6-shaw.leon@gmail.com>

From: Xiao Liang <shaw.leon@xxxxxxxxx>
Date: Wed, 19 Feb 2025 20:50:31 +0800
> ip_tunnel_init() is called from register_netdevice(). In all code paths
> reaching here, tunnel->net should already have been set (either in
> ip_tunnel_newlink() or __ip_tunnel_create()). So don't set it again.
> 
> Signed-off-by: Xiao Liang <shaw.leon@xxxxxxxxx>

Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>

References:
- [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init()
  - From: Xiao Liang

Prev by Date: Re: [PATCH net-next v10 02/13] rtnetlink: Pack newlink() params into struct
Next by Date: Re: [PATCH net-next v10 06/13] net: ip_tunnel: Use link netns in newlink() of rtnl_link_ops
Previous by thread: [PATCH net-next v10 05/13] net: ip_tunnel: Don't set tunnel->net in ip_tunnel_init()
Next by thread: [PATCH net-next v10 06/13] net: ip_tunnel: Use link netns in newlink() of rtnl_link_ops
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]