RE: [PATCH v1 2/3] wifi: rtl8xxxu: Use macid in rtl8xxxu_fill_txdesc_v1()

Ping-Ke Shih <pkshih@xxxxxxxxxxx> · Thu, 20 Feb 2025 06:00:46 +0000



Ezra Buehler <ezra@xxxxxxxx> wrote:
> From: Ezra Buehler <ezra.buehler@xxxxxxxxxxxxxxxxxx>
> 
> This is needed in order for AP mode to work correctly on gen1 devices
> like the RTL8192CU.
> 
> For more information, see the corresponding change for gen2 devices,
> commit 9aa45598d054 ("wifi: rtl8xxxu: Put the macid in txdesc").
> 
> Signed-off-by: Ezra Buehler <ezra.buehler@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/core.c     | 2 ++
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> index cbd9efd22e3f..2fa22d3145a4 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> @@ -5302,6 +5302,8 @@ rtl8xxxu_fill_txdesc_v1(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr,
>                 dev_info(dev, "%s: TX rate: %d, pkt size %u\n",
>                          __func__, rate, le16_to_cpu(tx_desc->pkt_size));
> 
> +       tx_desc->txdw1 |= cpu_to_le32(macid & TXDESC32_MACID_MASK);
> +

tx_desc->txdw1 |= le32_encode_bits(macid, TXDESC32_MACID_MASK);