Hi Luiz,
thanks for the prompt review !
On 2/12/25 17:14, Luiz Augusto von Dentz wrote:
[...]
>> +static int wilc_open(struct hci_uart *hu)
>> +{
>> + struct wilc_data *wdata;
>> +
>> + BT_DBG("hci_wilc: open");
>
> Afaik you don't need to include the function name with the likes of
> pr_debug/BT_DBG, that said you should really be using bt_dev_dbg if
> you have hu->hdev set at this point, and this is valid for all other
> places where BT_DBG could be replaced with bt_dev_dbg.
I observe that BT_DBG does not bring any kind of prefix to the emitted log. But
indeed, bt_dev_dbg looks definitely better for my purpose, I'll update all those
logs with it.
>> + wdata = kzalloc(sizeof(*wdata), GFP_KERNEL);
>> + if (!wdata)
>> + return -ENOMEM;
>
> Add an empty after something like an if statement to make it clearer
> that it is not under the same scope.
True, that will be fixed.
[...]
>
> Once you address these comments please fill free to add:
>
> Reviewed-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx>
Thanks. I'll delay v2 for a few days to let other people review the series.
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
