Search Linux Wireless

RE: [PATCH 2/2] wifi: rtw89: rtw8852b{t}: fix TSSI debug timestamps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dmitry Antipov <dmantipov@xxxxxxxxx> wrote:
> Assuming that 'tssi_alimk_time' of 'struct rtw89_tssi_info' is
> in milliseconds,

Checking vendor driver, It intends microseconds. 

	RF_DBG(rf, DBG_RF_TX_PWR_TRACK, "[TSSI PA K] %s processing time = %d.%dms\n",
		__func__,
		HALRF_ABS(finish_time, start_time) / 1000,
		HALRF_ABS(finish_time, start_time) % 1000);

> adjust rtw8852b{t}-specific '_tssi_alimentk()'
> to not mix the former with nanoseconds. Compile tested only.
> 
> Fixes: 7f18a70d7b4d ("wifi: rtw89: 8852b: rfk: add TSSI")
> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>
> ---
>  drivers/net/wireless/realtek/rtw89/core.h          | 2 +-
>  drivers/net/wireless/realtek/rtw89/rtw8852b_rfk.c  | 9 ++++-----
>  drivers/net/wireless/realtek/rtw89/rtw8852bt_rfk.c | 9 ++++-----
>  3 files changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/core.h b/drivers/net/wireless/realtek/rtw89/core.h
> index ff4894c7fa8a..93e41def81b4 100644
> --- a/drivers/net/wireless/realtek/rtw89/core.h
> +++ b/drivers/net/wireless/realtek/rtw89/core.h
> @@ -5135,7 +5135,7 @@ struct rtw89_tssi_info {
>         u32 alignment_backup_by_ch[RF_PATH_MAX][TSSI_MAX_CH_NUM][TSSI_ALIMK_VALUE_NUM];
>         u32 alignment_value[RF_PATH_MAX][TSSI_ALIMK_MAX][TSSI_ALIMK_VALUE_NUM];
>         bool alignment_done[RF_PATH_MAX][TSSI_ALIMK_MAX];
> -       u32 tssi_alimk_time;
> +       u64 tssi_alimk_time;

This is the accumulated time of doing alimk, so debug message would be 

	rtw89_debug(rtwdev, RTW89_DBG_RFK,
		        "[TSSI PA K] %s processing time = %d.%d ms (acc = %d.%d ms)\n",








[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux