On Mon, 2025-01-27 at 17:26 +0100, Alexander Wetzel wrote: > > +static int ac_has_active_txq(struct ieee80211_local *local) > +{ > + int ac; > + > + for (ac = 0; ac < IEEE80211_NUM_ACS; ac++) { > + spin_lock_bh(&local->active_txq_lock[ac]); > + if (!list_empty(&local->active_txqs[ac])) > + goto out; > + spin_unlock_bh(&local->active_txq_lock[ac]); > + } > + return IEEE80211_NUM_ACS; > +out: > + spin_unlock_bh(&local->active_txq_lock[ac]); > + return ac; > +} Could use guard() here, and simplify that, I think :) johannes