On 2/4/25 23:58, Aloka Dixit wrote:
On 2/3/2025 8:41 PM, Aditya Kumar Singh wrote:
On 2/4/25 03:14, Aloka Dixit wrote:
Function ath11k_mac_setup_bcn_tmpl() retrieves tx_arvif only for
a sanity check and then calls ath11k_mac_setup_bcn_tmpl_mbssid()
or ath11k_mac_setup_bcn_tmpl_ema() both of which again retrieve
the same pointer. Instead store the pointer and pass it to the
latter two functions.
Same, Is this tested? Perhaps you forgot to add "Tested-on:" tag?
Signed-off-by: Aloka Dixit <aloka.dixit@xxxxxxxxxxxxxxxx>
---
No, only ath12k patches are tested hence no tag here for ath11k.
This patch doesn't change handling functionally and I confirmed that all
places using 'tx_arvif' first do NULL check because the refactored
function can return NULL. Functions ath11k_mac_setup_bcn_tmpl_mbssid()
and ath11k_mac_setup_bcn_tmpl_ema() always receive a non-NULL value now
because the caller ath11k_mac_setup_bcn_tmpl() sets 'tx_arvif = arvif'
whenever applicable.
Okay so in that case "No functionality change. Compile tested only."
line should be there in commit text?
--
Aditya
