On Tue Feb 4, 2025 at 5:23 AM CET, Aditya Kumar Singh wrote: > Currently, links in an interface are allocated during channel assignment > via assign_vif_chanctx(). Conversely, links are deleted during channel > unassignment via unassign_vif_chanctx(). However, deleting links during > channel unassignment does not comply with mac80211 link handling. > Therefore, this process should be managed within change_vif_links(). > > This series aims to add support to handle links in change_vif_links() > callback. > > Patches 1-2 are making debug infra to work without device info. > > Patches 3-8 are the ones changing the code to handle as mentioned above. > > NOTE: > * A new ath12k-check warning comes which probably needs to be added to > ignore list > > drivers/net/wireless/ath/ath12k/debug.c:69: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... > > This is because, since device info is not known can not use netdev_ or dev_ > dbg family. pr_debug() is an option but that will require DYNAMIC_DEBUG > and then ath12k needs to be probed with dyndbg=+p which we don't want in > ath. Hence, only option left is to use printk() directly. > Hello, When applying this series I am no longer able to start an AP on a DFS channel. (I don't know specifically which patch though) After the initial CAC period I get the following kernel message: [ 45.248441] ath12k_pci 0003:01:00.0: cannot install key for non-existent peer 3a:07:16:d8:00:08 And then hostapd goes in failed state: wlan0: interface state UNINITIALIZED->COUNTRY_UPDATE ACS: Automatic channel selection started, this may take a bit wlan0: interface state COUNTRY_UPDATE->ACS wlan0: ACS-STARTED wlan0: ACS-COMPLETED freq=5620 channel=124 wlan0: interface state ACS->DFS wlan0: DFS-CAC-START freq=5620 chan=124 sec_chan=1, width=2, seg0=114, seg1=0, cac_time=5s wlan0: DFS-CAC-COMPLETED success=1 freq=5620 ht_enabled=0 chan_offset=0 chan_width=5 cf1=5570 cf2=0 radar_detected=0 wlan0: nl80211: kernel reports: key addition failed Interface initialization failed wlan0: interface state DFS->DISABLED wlan0: AP-DISABLED Maybe I missed something ? Is there another series this one depends upon that I should have applied before ? Thanks