Re: [PATCH v9 7/9] wifi: ath12k: clean up 80P80 support

[Maxime Bizon <mbizon@xxxxxxxxxx>]

On Mon, 2025-01-13 at 16:38 -0800, Pradeep Kumar Chitrapu wrote:

Hello,

> @@ -2859,16 +2848,11 @@ static enum wmi_phy_mode ath12k_mac_get_phymode_vht(struct ath12k *ar,
>                                                     struct ieee80211_link_sta *link_sta)
>  {
>         if (link_sta->bandwidth == IEEE80211_STA_RX_BW_160) {
> -               switch (link_sta->vht_cap.cap &
> -                       IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_MASK) {
> -               case IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ:
> -                       return MODE_11AC_VHT160;
> -               case IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160_80PLUS80MHZ:
> -                       return MODE_11AC_VHT80_80;
> -               default:
> -                       /* not sure if this is a valid case? */
> +               if (link_sta->vht_cap.cap &
> +                   IEEE80211_VHT_CAP_SUPP_CHAN_WIDTH_160MHZ)
>                         return MODE_11AC_VHT160;
> -               }
> +
> +               return MODE_UNKNOWN;


This breaks VHT 160Mhz for STA with NSS restriction.

Those don't set VHT_CAP_SUPP_CHAN_WIDTH_160MHZ (see
IEEE80211_VHT_EXT_NSS_BW_CAPABLE)

-- 
Maxime