Johannes Berg wrote: > On Wed, 2008-12-31 at 15:39 +0530, Sujith wrote: > > Move to the advertised channel on reception of > > a CSA element. This is needed for 802.11h compliance. > > > > Signed-off-by: Sujith <Sujith.Manoharan@xxxxxxxxxxx> > > One thing I've been wondering about though, should we have a hook into > the driver to actually stop transmit at a lower level, where possible? > For example Broadcom hardware we can actually set some value on the chip > and then let it reject all frames, drain its FIFOs, and then in the > driver we could schedule those frames again for afterwards. I think that is needed only when handling Quiet IE, which I was planning to work on separately, with a notification to the driver to stop transmission completely for a period of time. > > + sdata->local->oper_channel = new_ch; > > Here you're setting oper_channel, but is that really the right thing to > do? That means any hw config call that comes in between this and later > will already switch to that channel, and hw config can happen for > various other reasons, for instance PS mode stuff. I think we may need > to have a separate variable? Right, a *switch_to in sdata would suffice, I guess. I'll send an updated patch. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
