On 1/24/2025 8:55 PM, Aditya Kumar Singh wrote: > On 1/24/25 14:30, Tamizh Chelvam Raja wrote: >> From: Avula Sri Charan <quic_asrichar@xxxxxxxxxxx> >> >> In case of MHI error a reset work will be queued >> which will try napi_disable after napi_synchronize. > > nit: always better to refer function name with () at end. I guess Jeff > can fix in pending? I fixed this, as well as did some other grammar & formatting fixes. Please check: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=a644c8784220b7d5dd0a10a45c5e6779605778a5 > >> >> As the napi will be only enabled after qmi_firmware_ready >> event trying napi_synchronize before napi_enable will >> result in indefinite sleep in case of a firmware crash >> in QMI init sequence. >> >> To avoid this introduce napi_enabled flag to check >> if napi is enabled or not before calling napi_synchronize. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Avula Sri Charan <quic_asrichar@xxxxxxxxxxx> >> Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@xxxxxxxxxxx> >> --- > > Reviewed-by: Aditya Kumar Singh <aditya.kumar.singh@xxxxxxxxxxxxxxxx> >
