Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote: > After the firmware is uploaded, download_firmware_validate() checks some > bits in REG_MCUFW_CTRL to see if everything went okay. The > RTL8814AU power on sequence sets bits 13 and 12 to 2, which this > function does not expect, so it thinks the firmware upload failed. > > Make download_firmware_validate() ignore bits 13 and 12. > > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> Memo some traces from vendor driver: For most chips, poll firmware ready by while (HALMAC_REG_R16(REG_MCUFW_CTRL) != 0xC078) Other chips check ready by while ((HALMAC_REG_R16(REG_MCUFW_CTRL) & 0xC078) != 0xC078) And, for all chips, BIT 12-13 are defined as CPU_CLK_SEL, so I think this change is well.
