On 1/22/2025 8:46 AM, Aditya Kumar Singh wrote: > On 1/22/25 21:31, Nicolas Escande wrote: >> When vlan support was added, we missed that when >> ath12k_dp_prepare_htt_metadata returns an error we also need to free the > > nit: Always refer function name with () for clarity. > >> skb holding the metadata before going on with the cleanup process. >> Compile tested only. >> >> Fixes: 26dd8ccdba4d ("wifi: ath12k: dynamic VLAN support") >> Signed-off-by: Nicolas Escande <nico.escande@xxxxxxxxx> >> --- > > If there's going to be a new version please take care of above nit > comment. Otherwise - > > Reviewed-by: Aditya Kumar Singh <aditya.kumar.singh@xxxxxxxxxxxxxxxx> > > I'll fixup () in both subject and description