Re: [PATCH v3] wifi: ath12k: Add WMI control path stats infra

[Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx>]

On 1/21/25 00:14, Ramya Gnanasekar wrote:
> @@ -559,6 +559,13 @@ struct ath12k_debug {
>   	struct dentry *debugfs_pdev;
>   	struct dentry *debugfs_pdev_symlink;
>   	struct ath12k_dbg_htt_stats htt_stats;
> +	struct ath12k_wmi_ctrl_path_stats_list wmi_ctrl_path_stats;
> +	enum wmi_tlv_tag wmi_ctrl_path_stats_tagid;
> +	struct completion wmi_ctrl_path_stats_rcvd;
> +	u8 wmi_ctrl_path_stats_reqid;
> +	/* To protect wmi_list manipulation */
> +	spinlock_t  wmi_ctrl_path_stats_lock;

nit: extra space between type and name

@@ -92,6 +243,11 @@ void ath12k_debugfs_register(struct ath12k *ar)
>   	}
>   
>   	ath12k_debugfs_htt_stats_register(ar);
> +
> +	if (test_bit(WMI_TLV_SERVICE_CTRL_PATH_STATS_REQUEST,
> +		     ar->ab->wmi_ab.svc_map))
> +		ath12k_debugfs_wmi_ctrl_stats_register(ar);
> +
>   }

drivers/net/wireless/ath/ath12k/debugfs.c:251: Blank lines aren't necessary before a close brace '}'

--
Aditya