Search Linux Wireless

Re: [PATCH] wifi: ath9k: adjust ath9k_rx_prepare() and simplify ath9k_rx_tasklet()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dmitry Antipov <dmantipov@xxxxxxxxx> writes:

> Adjust 'ath9k_rx_prepare()' to fill skb control buffer directly rather
> than using temporary 'struct ieee80211_rx_status' in 'ath9k_rx_tasklet()',
> thus making both temporary and 'memcpy()' redundant. Compile tested
> only.

Hmm, so the existing code follows the "perform checks, then write data"
pattern, which is generally good practice. I don't think saving a
48-byte memcpy() is worth it to deviate from this pattern. Certainly not
without testing :)

-Toke




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux