Hi Kalle,
Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
> When using allmodconfig, .config has CONFIG_LEDS_CLASS=m but
> autoconf.h has CONFIG_LEDS_CLASS_MODULE (additional suffix _MODULE)
> instead of CONFIG_LEDS_CLASS, which condition CONFIG_LEDS_CLASS in
> rtw88/led.h can't work properly.
>
> Add RTW88_LEDS to Kconfig, and use it as condition to fix this problem.
>
> drivers/net/wireless/realtek/rtw88/led.c:19:6: error: redefinition of 'rtw_led_init'
> 19 | void rtw_led_init(struct rtw_dev *rtwdev)
> | ^~~~~~~~~~~~
> In file included from drivers/net/wireless/realtek/rtw88/led.c:7:
> drivers/net/wireless/realtek/rtw88/led.h:15:20: note: previous definition of 'rtw_led_init' with type
> 'void(struct rtw_dev *)'
> 15 | static inline void rtw_led_init(struct rtw_dev *rtwdev)
> | ^~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/led.c:64:6: error: redefinition of 'rtw_led_deinit'
> 64 | void rtw_led_deinit(struct rtw_dev *rtwdev)
> | ^~~~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/led.h:19:20: note: previous definition of 'rtw_led_deinit' with type
> 'void(struct rtw_dev *)'
> 19 | static inline void rtw_led_deinit(struct rtw_dev *rtwdev)
> | ^~~~~~~~~~~~~~
>
> Fixes: 4b6652bc6d8d ("wifi: rtw88: Add support for LED blinking")
If this patch is good to you, please take it to wireless-next to fix the
problem caused by Commit 4b6652bc6d8d.
Assigned to you in patchwork. Thanks.
Ping-Ke
