On Mon, 2008-12-29 at 19:23 +0530, Vivek Natarajan wrote:
> +static inline void ath9k_ps_wakeup(struct ath_softc *sc)
> +{
> + if ((atomic_inc_return(&sc->ps_usecount) == 1) &&
> + (sc->sc_ah->ah_powerMode != ATH9K_PM_AWAKE)) {
> + sc->sc_ah->ah_restoreMode = sc->sc_ah->ah_powerMode;
> + ath9k_hw_setpower(sc->sc_ah, ATH9K_PM_AWAKE);
> + }
> +}
> +
> +static inline void ath9k_ps_restore(struct ath_softc *sc)
> +{
> + if (atomic_dec_and_test(&sc->ps_usecount) &&
> + (sc->hw->conf.flags & IEEE80211_CONF_PS))
> + ath9k_hw_setpower(sc->sc_ah, sc->sc_ah->ah_restoreMode);
Not sure which is intended, but maybe you should do the flags/powermode
check before doing the refcount change? In either case, I would probably
nest it into two if statements so it's clear which one is intended?
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
