Re: [PATCH RFC 3/7] wifi: cfg80211: extend statistics for link level in sinfo

[Sarika Sharma <quic_sarishar@xxxxxxxxxxx>]

On 1/10/2025 2:51 PM, Johannes Berg wrote:
> On Fri, 2025-01-10 at 09:54 +0530, Sarika Sharma wrote:
> > The statistics could be embedded into NL message as below:
> > For MLO:
> > cmd ->
> > 	NL80211_ATTR_IFINDEX
> > 	NL80211_ATTR_MAC
> > 	NL80211_ATTR_GENERATION
> > 	.......etc
> > 	NL80211_ATTR_STA_INFO | nest flag
> > 		NL80211_STA_INFO_CONNECTED_TIME,
> > 		NL80211_STA_INFO_STA_FLAGS,
> > 		........etc
> > 	NL80211_ATTR_MLO_LINK_ID,
> > 	NL80211_ATTR_MLD_ADDR,
> > 	NL80211_ATTR_MLO_LINKS | nested
> > 		link_id-1 | nested
> > 		NL80211_ATTR_MLO_LINK_ID,
> > 		NL80211_ATTR_MLD_ADDR,
>
> Using the MLD_ADDR attribute here seems really odd?

Oops! looks here I keep it as MLD_ADDR by mistake, it is 
NL80211_ATTR_MAC attribute that is filled in code.
Thankyou for pointing out, will correct it here.

> Also I think you got the indentation wrong.
>
> > 			NL80211_ATTR_STA_INFO | nest flag
> > 				NL80211_STA_INFO_RX_BYTES,
> > 				NL80211_STA_INFO_TX_BYTES,
> > 				..........etc.
>
> johannes