Pavel Roskin <proski@xxxxxxx> writes: > On Sun, 2008-12-28 at 20:54 +0200, Kalle Valo wrote: >> Fixes sparse warnings: >> >> net/mac80211/util.c:355:6: warning: symbol >> 'ieee80211_wake_queue_by_reason' was not declared. Should it be static? >> net/mac80211/util.c:385:6: warning: symbol >> 'ieee80211_stop_queue_by_reason' was not declared. Should it be static? > > ... > >> +void ieee80211_wake_queue_by_reason(struct ieee80211_hw *hw, int queue, >> + enum queue_stop_reason reason); >> +void ieee80211_stop_queue_by_reason(struct ieee80211_hw *hw, int queue, >> + enum queue_stop_reason reason); > > What's the point in declaring functions that are not used elsewhere? > Why not make them static as sparse suggests? I was thinking that maybe in the the future the are other users in mac80211, but your comment made me rethink this and I agree with you, they should be static. Please forget this patch, I'll send a new one. > And if those function are going to be used by other modules, maybe > they should be exported? This is a mac80211 internal interface, not to be used by the drivers. So it should not be exported. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
