Re: [PATCH v2] wifi: cfg80211: skip regulatory checks when the channel is punctured

Kavita Kavita <quic_kkavita@xxxxxxxxxxx> · Thu, 9 Jan 2025 14:25:31 +0530

On 12/19/2024 5:35 PM, Johannes Berg wrote:
On Thu, 2024-12-19 at 17:29 +0530, Kavita Kavita wrote:

For example,

Please refer below Implementation of cfg80211_get_chans_dfs_required:

for (freq = start_freq; freq <= end_freq; freq += MHZ_TO_KHZ(20)) {
	c = ieee80211_get_channel_khz(wiphy, freq);
	if (!c)
		return -EINVAL;

I handled this above "if" case within the macro itself, so when this
case occurs, the loop terminates and does not check further subchannels.

Oh. Hmm. I'd be surprised if we don't have anything that checks for this
elsewhere and we even _need_ this check, but I suppose it's possible and
then the macro should actually just have a NULL channel pointer for one
of the iterations so the user can check?

Yes, we have fixed it in v3 patch. Thanks.

johannes