Hi Bitterblue, kernel test robot noticed the following build errors: [auto build test ERROR on wireless-next/main] [also build test ERROR on wireless/main linus/master v6.13-rc6 next-20241220] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bitterblue-Smith/wifi-rtw88-Add-support-for-LED-blinking/20250106-030830 base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main patch link: https://lore.kernel.org/r/57c7d192-97ee-4da1-87a8-f040e9b8e3d1%40gmail.com patch subject: [PATCH v2] wifi: rtw88: Add support for LED blinking config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250106/202501061046.U1iOSkRv-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250106/202501061046.U1iOSkRv-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202501061046.U1iOSkRv-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): >> drivers/net/wireless/realtek/rtw88/led.c:19:6: error: redefinition of 'rtw_led_init' 19 | void rtw_led_init(struct rtw_dev *rtwdev) | ^~~~~~~~~~~~ In file included from drivers/net/wireless/realtek/rtw88/led.c:7: drivers/net/wireless/realtek/rtw88/led.h:15:13: note: previous definition of 'rtw_led_init' with type 'void(struct rtw_dev *)' 15 | static void rtw_led_init(struct rtw_dev *rtwdev) | ^~~~~~~~~~~~ >> drivers/net/wireless/realtek/rtw88/led.c:64:6: error: redefinition of 'rtw_led_deinit' 64 | void rtw_led_deinit(struct rtw_dev *rtwdev) | ^~~~~~~~~~~~~~ drivers/net/wireless/realtek/rtw88/led.h:19:13: note: previous definition of 'rtw_led_deinit' with type 'void(struct rtw_dev *)' 19 | static void rtw_led_deinit(struct rtw_dev *rtwdev) | ^~~~~~~~~~~~~~ >> drivers/net/wireless/realtek/rtw88/led.h:19:13: warning: 'rtw_led_deinit' defined but not used [-Wunused-function] >> drivers/net/wireless/realtek/rtw88/led.h:15:13: warning: 'rtw_led_init' defined but not used [-Wunused-function] 15 | static void rtw_led_init(struct rtw_dev *rtwdev) | ^~~~~~~~~~~~ vim +/rtw_led_init +19 drivers/net/wireless/realtek/rtw88/led.c 18 > 19 void rtw_led_init(struct rtw_dev *rtwdev) 20 { 21 static const struct ieee80211_tpt_blink rtw_tpt_blink[] = { 22 { .throughput = 0 * 1024, .blink_time = 334 }, 23 { .throughput = 1 * 1024, .blink_time = 260 }, 24 { .throughput = 5 * 1024, .blink_time = 220 }, 25 { .throughput = 10 * 1024, .blink_time = 190 }, 26 { .throughput = 20 * 1024, .blink_time = 170 }, 27 { .throughput = 50 * 1024, .blink_time = 150 }, 28 { .throughput = 70 * 1024, .blink_time = 130 }, 29 { .throughput = 100 * 1024, .blink_time = 110 }, 30 { .throughput = 200 * 1024, .blink_time = 80 }, 31 { .throughput = 300 * 1024, .blink_time = 50 }, 32 }; 33 struct led_classdev *led = &rtwdev->led_cdev; 34 int err; 35 36 if (!rtwdev->chip->ops->led_set) 37 return; 38 39 if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_USB) 40 led->brightness_set_blocking = rtw_led_set_blocking; 41 else 42 led->brightness_set = rtwdev->chip->ops->led_set; 43 44 snprintf(rtwdev->led_name, sizeof(rtwdev->led_name), 45 "rtw88-%s", dev_name(rtwdev->dev)); 46 47 led->name = rtwdev->led_name; 48 led->max_brightness = LED_ON; 49 led->default_trigger = 50 ieee80211_create_tpt_led_trigger(rtwdev->hw, 51 IEEE80211_TPT_LEDTRIG_FL_RADIO, 52 rtw_tpt_blink, 53 ARRAY_SIZE(rtw_tpt_blink)); 54 55 err = led_classdev_register(rtwdev->dev, led); 56 if (err) { 57 rtw_warn(rtwdev, "Failed to register the LED, error %d\n", err); 58 return; 59 } 60 61 rtwdev->led_registered = true; 62 } 63 > 64 void rtw_led_deinit(struct rtw_dev *rtwdev) -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
