On 20.12.2024 11:05 PM, Konrad Dybcio wrote: > On 20.12.2024 10:47 PM, Jeff Johnson wrote: >> On 12/20/2024 12:03 PM, Konrad Dybcio wrote: >>> On 5.11.2024 7:04 PM, Raj Kumar Bhagat wrote: >>>> The QCN9274 WiFi device supports WSI (WLAN Serial Interface). WSI is used >>>> to exchange specific control information across radios using a doorbell >>>> mechanism. This WSI connection is essential for exchanging control >>>> information among these devices. The WSI interface in the QCN9274 includes >>>> TX and RX ports, which are used to connect multiple WSI-supported devices >>>> together, forming a WSI group. >>>> >>>> Describe QCN9274 PCI wifi device with WSI interface. >>>> >>>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@xxxxxxxxxxx> >>>> --- >>> >>> I think this description is missing the key points: >>> >>> * what is that control information (power, data, radio stuff?) >>> * what happens when the OS is unaware of all of this (i.e. what happens when >>> we don't send any configuration) >>> * is this configurable, or does this describe a physical wiring topology >>> (what/who decides which of the group configurations detailed below take >>> effect) >>> >>> And the ultimate question: >>> * can the devices not just talk among themselves and negotiate that? >>> >>> Though AFAICU PCIe P2P communication is a shaky topic, so perhaps the answer >>> to the last question is 'no' >>> >>> Konrad >> >> We already pushed the non-RFC version to our -next tree so we cannot update >> the commit description without a forced push. >> >> https://lore.kernel.org/all/20241211153432.775335-2-kvalo@xxxxxxxxxx/ >> >> However, Raj Kumar can submit an update to the description in the file, which >> is probably the better place to have this information anyway. > > Sounds good (although bindings usually land with Krzysztof's or Rob's review tags, but that's between you and them to talk about now) Konrad
