Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote: > > + > > +static void rtw_usb_phy_write(struct rtw_dev *rtwdev, u16 addr, u16 data, > > + enum usb_device_speed speed) > > +{ > > + if (speed == USB_SPEED_SUPER) { > > + rtw_write8(rtwdev, 0xff0d, (u8)data); > > + rtw_write8(rtwdev, 0xff0e, (u8)(data >> 8)); > > + rtw_write8(rtwdev, 0xff0c, addr | BIT(7)); > > The casting of u8 is not unnecessary. > Sorry for the typo. I meant "... is not necessary."