Search Linux Wireless

RE: [PATCH v2 1/3] wifi: rtw88: usb: Copy instead of cloning the RX skb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
> 
> On 19/12/2024 08:17, Ping-Ke Shih wrote:
> > Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
> >
> >> +                       skb = alloc_skb(skb_len, GFP_KERNEL);
> >> +                       if (!skb) {
> >> +                               rtw_dbg(rtwdev, RTW_DBG_USB,
> >> +                                       "failed to allocate RX skb of size %u\n",
> >> +                                       skb_len);
> >
> > checkpatch warns this is unnecessary.
> >
> > WARNING: Possible unnecessary 'out of memory' message
> > #94: FILE: drivers/net/wireless/realtek/rtw88/usb.c:591:
> > +                       if (!skb) {
> > +                               rtw_dbg(rtwdev, RTW_DBG_USB,
> >
> >
> >
> 
> checkpatch is wrong about this one. alloc_skb doesn't say
> anything when it fails.

Got it. Then

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>






[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux