Karthikeyan Periyasamy <quic_periyasa@xxxxxxxxxxx> writes: > On 12/19/2024 5:04 PM, Kalle Valo wrote: >> Karthikeyan Periyasamy <quic_periyasa@xxxxxxxxxxx> writes: >> >>> Currently, ath12k_dp_mon_rx_parse_status_tlv() takes the TLV tag, TLV data >>> and TLV userid as separate arguments from the caller. These argument can >>> be fetched from the TLV header itself. Therefore, pass the TLV header and >>> retrieve the necessary fields from the header instead of passing them from >>> the caller. >> The commit message doesn't reply to "why?". Is there a clear benefit >> in >> the future or are you just doing random code cleanup? >> > > It benefit in the future for supporting EHT monitor functionality. How does it help exactly? Having even just one sentence explaining the motivation in the commit message would help a lot. Otherwise these just look random changes. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
