Karthikeyan Periyasamy <quic_periyasa@xxxxxxxxxxx> writes: > Currently, the pdev handle is given along with the mac id to all the > monitor Tx/Rx handler procedure arguments. The mac id information is > derived from the pdev handle itself. Therefore, remove the unnecessary > mac id argument from the handler. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@xxxxxxxxxxx> > --- > drivers/net/wireless/ath/ath12k/dp_mon.c | 29 ++++++++++++------------ > drivers/net/wireless/ath/ath12k/dp_mon.h | 7 +++--- > 2 files changed, 17 insertions(+), 19 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c > index 85ff89b91624..ae2f6847bc88 100644 > --- a/drivers/net/wireless/ath/ath12k/dp_mon.c > +++ b/drivers/net/wireless/ath/ath12k/dp_mon.c > @@ -845,7 +845,7 @@ static void ath12k_dp_mon_rx_msdus_set_payload(struct ath12k *ar, > } > > static struct sk_buff * > -ath12k_dp_mon_rx_merg_msdus(struct ath12k *ar, u32 mac_id, > +ath12k_dp_mon_rx_merg_msdus(struct ath12k *ar, BTW I find it confusing that in the commit message you talk about "pdev handle" but in the code it's named "ar". It would be nice to have terminology all over. No need to change anything for this patch, just a small comment for the future. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
