On 19/12/2024 05:47, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
>>
>> RTL8821AE is stuck transmitting at the lowest rate allowed by the rate
>> mask. This is because the firmware doesn't know the device is connected
>> to a network.
>>
>> Fix the macros SET_H2CCMD_MSRRPT_PARM_OPMODE and
>> SET_H2CCMD_MSRRPT_PARM_MACID_IND to work on the first byte of __cmd,
>> not the second. Now the firmware is correctly notified when the device
>> is connected to a network and it activates the rate control.
>>
>> Before (MCS3):
>>
>> [ 5] 0.00-1.00 sec 12.5 MBytes 105 Mbits/sec 0 339 KBytes
>> [ 5] 1.00-2.00 sec 10.6 MBytes 89.1 Mbits/sec 0 339 KBytes
>> [ 5] 2.00-3.00 sec 10.6 MBytes 89.1 Mbits/sec 0 386 KBytes
>> [ 5] 3.00-4.00 sec 10.6 MBytes 89.1 Mbits/sec 0 386 KBytes
>> [ 5] 4.00-5.00 sec 10.2 MBytes 86.0 Mbits/sec 0 427 KBytes
>>
>> After (MCS9):
>>
>> [ 5] 0.00-1.00 sec 33.9 MBytes 284 Mbits/sec 0 771 KBytes
>> [ 5] 1.00-2.00 sec 31.6 MBytes 265 Mbits/sec 0 865 KBytes
>> [ 5] 2.00-3.00 sec 29.9 MBytes 251 Mbits/sec 0 963 KBytes
>> [ 5] 3.00-4.00 sec 28.2 MBytes 237 Mbits/sec 0 963 KBytes
>> [ 5] 4.00-5.00 sec 26.8 MBytes 224 Mbits/sec 0 963 KBytes
>>
>> Fixes: 39f40710d0b5 ("rtlwifi: rtl88821ae: Remove usage of private bit manipulation macros")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx>
>
> Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> Is this an urgent patch? or it's fine to go via rtw-next?
>
>
It's not urgent for me, rtw-next is fine.
