On Tue, Dec 17, 2024 at 3:31 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > Linus Walleij <linus.walleij@xxxxxxxxxx> writes: > > > A recent refactoring was identified by static analysis to > > cause another potential NULL dereference, fix this! > > > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Closes: https://lore.kernel.org/r/202411271742.Xa7CNVh1-lkp@xxxxxxxxx/ > > Fixes: 2719a9e7156c ("wifi: cw1200: Convert to GPIO descriptors") > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > If it's ok for you, I'll add the smatch warning to the commit message: > > drivers/net/wireless/st/cw1200/cw1200_spi.c:440 cw1200_spi_disconnect() error: we previously assumed 'self' could be null (see line 433) Sure go ahead! Yours, Linus Walleij