On 12/14/2024 9:29 AM, Toke Høiland-Jørgensen wrote:
> Toke Høiland-Jørgensen <toke@xxxxxxx> writes:
>
>> Dmitry Antipov <dmantipov@xxxxxxxxx> writes:
>>
>>> Prefer 'ktime_t' over 'struct timespec64' for 'struct ath_chanctx' and
>>> 'struct ath_softc' timestamps, choose standard kernel time API over an
>>> ad-hoc math in 'chanctx_event_delta()' and 'ath9k_hw_get_tsf_offset()',
>>> adjust related users. Compile tested only.
>>>
>>> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>
>>
>> Nice cleanup! Just one formatting nit:
>>
>> [...]
>>> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
>>> index 2f137856a823..cf664a0dedaa 100644
>>> --- a/drivers/net/wireless/ath/ath9k/main.c
>>> +++ b/drivers/net/wireless/ath/ath9k/main.c
>>> @@ -247,10 +247,8 @@ static bool ath_complete_reset(struct ath_softc *sc, bool start)
>>> if (!sc->cur_chan->offchannel && start) {
>>> /* restore per chanctx TSF timer */
>>> if (sc->cur_chan->tsf_val) {
>>> - u32 offset;
>>> -
>>> - offset = ath9k_hw_get_tsf_offset(&sc->cur_chan->tsf_ts,
>>> - NULL);
>>> + u32 offset = ath9k_hw_get_tsf_offset
>>> + (sc->cur_chan->tsf_ts, 0);
>>
>> This turned into a really odd line break. Let's just keep the variable
>> definition on its own line like it was before, so we can keep the
>> function call the way it is as well...
>
> And since Jeff has agreed to fix the line break when applying, with that
> fixed:
>
> Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>
>
Please check:
https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pending&id=d953ce0fcc7ce69edb5a3a39ea3a98ba2347976d
